Merge pull request #104 from skx/101-fuzzer

Resolved fuzzer failures.

eval/eval.go

@@ -344,7 +344,14 @@ func (ev *Eval) eval(exp primitive.Primitive, e *env.Environment, expandMacro bo
 		//
 		// Now we're only dealing with lists
 		//
-		listExp := exp.(primitive.List)
+		listExp, listOk := exp.(primitive.List)
+
+		//
+		// But just in case we're not ..
+		//
+		if !listOk {
+			return primitive.Error(fmt.Sprintf("argument not a list for a function call: %v", exp))
+		}
 
 		//
 		// Is this an empty list?  Then just return it

eval/eval_test.go

@@ -390,6 +390,10 @@ a
 		{input: "(define blah (lambda (a:number) (print a))) (blah '(3))", output: "ERROR{TypeError - argument a to blah was supposed to be number, got list}"},
 		{input: "(define blah (lambda (a:function) (print a))) (blah '(3))", output: "ERROR{TypeError - argument a to blah was supposed to be function, got list}"},
 		{input: "(define blah (lambda (a:any) (print a))) (blah '(3))", output: "(3)"},
+
+		// fuzz errors
+		{input: "(defmacro! unless(fn*()`(~!)))(unless )", output: "ERROR{argument '(lambda (x) (if x #f #t))' not a function}"},
+		{input: "(ord 0)", output: "ERROR{argument not a character/string, got number}"},
 	}
 
 	for _, test := range tests {

fuzz_test.go

@@ -126,6 +126,7 @@ func FuzzYAL(f *testing.F) {
 		"invalid character literal",
 		"is not a symbol",
 		"must have even length",
+		"not a character",
 		"not a function",
 		"not a hash",
 		"not a list",

testdata/fuzz/FuzzYAL/ba0fcef6ab521763179f52a1f2ef9fed78574074e826d61f9c362bd4ca07f62e

@@ -0,0 +1,2 @@
+go test fuzz v1
+[]byte("(defmacro! unless(fn*()`(~!)))(unless )")