Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LSP #111

Closed
skx opened this issue Dec 7, 2022 · 0 comments · Fixed by #112
Closed

Improve LSP #111

skx opened this issue Dec 7, 2022 · 0 comments · Fixed by #112

Comments

@skx
Copy link
Owner

skx commented Dec 7, 2022

  • Since we only complete on the standard library we should find the possible completions only once, and reuse them.
  • We should show function arguments in our on-hover implementation.
skx added a commit that referenced this issue Dec 10, 2022
@skx
Cache LSP completions.
50c9092 
This will close #111 by calculating possible completions only once,
and then reusing them for the duration of our LSP server.

This works because we only complete things within the standard-library
which won't change mid-execution.

If we ever supported completion of the users' code then this approach
would need to be revisited, but we don't do that and don't want to at
the moment.
@skx skx mentioned this issue Dec 10, 2022
Merged
@skx skx closed this as completed in #112 Dec 10, 2022
@skx skx mentioned this issue Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache LSP completions. skx/yal
1 participant
@skx