Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval is getting out of hand. #94

Closed
skx opened this issue Nov 13, 2022 · 0 comments · Fixed by #97
Closed

eval is getting out of hand. #94

skx opened this issue Nov 13, 2022 · 0 comments · Fixed by #97

Comments

@skx
Copy link
Owner

skx commented Nov 13, 2022

As noted in #93 our eval method is getting out of hand.

Break it down into smaller chunks, and make sure it doesn't have the struct-methods on the hot-path.
skx added a commit that referenced this issue Nov 13, 2022
@skx
Simplify our eval() method.
73593ed 
This commit is the first in a chain that will close #94, by
simplifying our eval method.

Here we've recognized that all of our simple types return
themselves when they're evaluated - so we've created a simple
"IsSimpleType" in our primitive interface.

This makes it easy for simple things to return themselves,
and no longer need to have a special case.
@skx skx mentioned this issue Nov 13, 2022
Merged
@skx skx closed this as completed in #97 Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify our eval() method. skx/yal
1 participant
@skx