hashes are implemented oddly #95
Comments
skx
added a commit
that referenced
this issue
Nov 13, 2022
Rather than evaluate their keys *every* time they are used we only do so once, at parse time, as we should have done from the start. This involved changing the signature of readExpression, but as a purely internal function that's 100% acceptible. This closes #95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a hash is created we populate the keys as expected, but we set the value to "readExpression..".
i.e. Hash values are not evaluated at creation time. Instead when a hash is returned as an object, via "eval" the values are evaluated then.
At the time this made sense because readExpression doesn't have access to the environment, nor does it keep track of the state of macros.
The code as-is is fine, but it requires evaluations when arrays are passed around which is gonna slow things down.
The text was updated successfully, but these errors were encountered: