More fixes. #118
Merged
More fixes. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
skx
commented
Dec 28, 2022
•
skx
commented
- Added appropriate range-checking on arguments to functions:
- (base) can only be used with a base 2 >= N <= 36
- (random) needs a number bigger than zero.
- Disappointingly these issues were not found by fuzz-testing.
- Updated to add all our examples to the fuzz-testing, and almost immediately found new issues.
- Added exceptions and sample test-cases to the PR.
* (base) can only be used with a base 2 >= N <= 36 * (random) needs a number bigger than zero.
This found new crashes almost immediately. Ouch.
|
Looks good now, an overnight run showed nothing new: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.