Fix KFP version to 1.8.10 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmendesky
commented
Jan 5, 2022
| @@ -5,10 +5,10 @@ description = "" | |||
| authors = [] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.7" | |||
| python = ">=3.7,<3.9" | |||
There was a problem hiding this comment.
needed because poetry update refused the less strict requirement due to TFX not being compatible
jmendesky
commented
Jan 5, 2022
| @@ -66,7 +66,7 @@ var _ = Context("Pipeline Workflows", func() { | |||
| WithQueryParam("name", wiremock.EqualTo(pipeline.Spec.ComputeVersion())). | |||
| WithQueryParam("pipelineid", wiremock.EqualTo(pipeline.Status.KfpId)). | |||
| WillReturn( | |||
| fmt.Sprintf(`{"id": "%s", "created_at": "2021-09-10T15:46:08Z", "name": "%s", "resource_references": [{"key": {"id": "%s", "apiResourceType": "PIPELINE"}, "name": "%s", "relationship": "OWNER"}]}`, | |||
| fmt.Sprintf(`{"id": "%s", "created_at": "2021-09-10T15:46:08Z", "name": "%s", "resource_references": [{"key": {"id": "%s", "type": "PIPELINE"}, "name": "%s", "relationship": "OWNER"}]}`, | |||
There was a problem hiding this comment.
This was actually wrong here but the KFP SDK has not checked this property before
lacarvalho91
approved these changes
Jan 5, 2022
paoloambrosio-skyuk
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poetry builddoes not considerpoetry.lockfor fixing concrete dependency versions and instead uses versions ranges frompyproject.toml.Related poetry issues:
The resulting docker container (which is built from a wheel), therefore, has the latest available KFP version 1.8.10 installed, which has changed its outputs from 1.8.4.
This change upgrades KFP to 1.8.10 and fixes the version in
pyproject.tomluntil poetry releases a fix for the issue above.KFP output changes: