Skip to content

Commit

Permalink
arm64: dts: oplus: lower max brightness level to 2047
Browse files Browse the repository at this point in the history 
It turns out that brightness level 4095 corresponds exactly to the same
level as High Brightness Mode. That doesn't sound all that bad at first,
until you realize that the user might assume that the range of
brightness levels that they can set w/o HBM is considered to be
relatively safe. As such, we can end up with users setting max 4096
brightness all the time when using their phone, because in their minds,
it's still "safer" than HBM.

Not only that, but for our panel, when disabling HBM, the brightness
level that the panel returns to seems to be the equivalent of doing
`bl_lvl % 2048`. As such, if the backlight level was set somewere
around 87% in Android (corresponding to around ~2048 in the bl_lvl
value), then turning off HBM (or exiting out of udfps fp auth) results
in the backlight drastically dropping until the user readjusts the
backlight again.

Now, the latter problem (brightness wraparound) could be solved by just
immediately setting the bl_lvl again after turning off HBM, but that
leaves the former problem still. And that begs the question: what does
OxygenOS do?

As it turns out, on stock OOS 12, the max brightness level that OOS will
let you set *normally* is 2047. The reason why the dts has the max level
set to 4095 instead is because OOS has a feature that lets you increase
the max brightness to 4095 while watching HDR content. We don't have
such a feature in AOSP.

As such, it makes more sense to just lower the max brightness range to
2047. HBM will still work as expected.

Change-Id: I30a96aa0b25d2694be0c678afa136957fee2f95c
  • Loading branch information
@jabashque
jabashque committed Oct 15, 2022
1 parent 3cfa5cc commit d4d1cde
Show file tree
Hide file tree
Showing 22 changed files with 44 additions and 44 deletions.
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19805/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd-evt.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19805/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2767,9 +2767,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19805/dsi-panel-oplus20828-samsung-amb655x-1080-2400-120fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,9 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <360>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19811/dsi-panel-oplus19811-samsung-1440-3168-dsc-cmd.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2105,9 +2105,9 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19811/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd-evt.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19811/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2767,9 +2767,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19811/dsi-panel-oplus20828-samsung-amb655x-1080-2400-120fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,9 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <360>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19821/dsi-panel-oplus19101samsung-amb655uv01-1080-2400-90fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,8 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19821/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd-evt.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19821/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2767,9 +2767,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19821/dsi-panel-oplus20828-samsung-amb655x-1080-2400-120fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,9 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <360>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19855/dsi-panel-oplus19101samsung-amb655uv01-1080-2400-90fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,8 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19855/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd-evt.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19855/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2767,9 +2767,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/19855/dsi-panel-oplus20828-samsung-amb655x-1080-2400-120fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,9 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <360>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/20801/dsi-panel-samsung_ams644vk04_fhd_dsc.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1290,8 +1290,8 @@
qcom,panel-supply-entries = <&dsi_panel_pwr_supply_samsung>;
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-default-level = <320>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/20809/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd-evt.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/20809/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2767,9 +2767,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/20809/dsi-panel-oplus20828-samsung-amb655x-1080-2400-120fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,9 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <360>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/20828/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd-evt.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2797,9 +2797,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/20828/dsi-panel-oplus20061-samsung-1440-3216-dsc-cmd.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2767,9 +2767,9 @@
qcom,mdss-dsi-dc-backlight-level = <520>;
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <400>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down
4 changes: 2 additions & 2 deletions arch/arm64/boot/dts/vendor/20828/dsi-panel-oplus20828-samsung-amb655x-1080-2400-120fps.dtsi
View file
Original file line number Diff line number Diff line change
Expand Up @@ -693,9 +693,9 @@
qcom,mdss-dsi-bl-pmic-control-type = "bl_ctrl_dcs";
qcom,mdss-dsi-bl-min-level = <1>;
qcom,mdss-dsi-bl-normal-max-level = <2047>;
qcom,mdss-dsi-bl-max-level = <4095>;
qcom,mdss-dsi-bl-max-level = <2047>;
qcom,mdss-brightness-normal-max-level = <2047>;
qcom,mdss-brightness-max-level = <4095>;
qcom,mdss-brightness-max-level = <2047>;
qcom,mdss-brightness-default-level = <360>;
qcom,platform-te-gpio = <&tlmm 66 0>;
qcom,platform-reset-gpio = <&tlmm 75 0>;
Expand Down

0 comments on commit d4d1cde

Please sign in to comment.