Fix. If the color defined in the entity is 256, the color used should be the one defined in the layer #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned in the entity instead of the layer, unless the color is 256. 256 is a special value to say that the entity has to use the color defined in the layer.
|
Thank you, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
256 is a special value to say that the color used should be the one defined in the layer.
I've experienced this problem with a DXF file that has red entity (it's rendered red in LibreCAD) but it was rendered in a different color when it was exported to SVG using this library.
train_with_red_entities.zip
Discussion about colors defined in the entity: [https://groups.google.com/g/comp.cad.autocad/c/onnSe9gdaV8/m/Nm-s-e2WuNEJ](https://groups.google.com/g/comp.cad.autocad/c/onnSe9gdaV8/m/Nm-s-e2WuNEJ