added LTYPE table parser. Necessary to create patterns for dashed lines #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good improvement feature-wise! The diff is huge however and from what I can see it is mostly formatting that has changed. Would it be possible to revert that so that the diff only includes implementation changes? Would also be nice with some test case that shows how it is supposed to work. |
|
My mistake, didn't realize that before uploading it. I will try to fix this, or if I can't I will upload another PR with a use case included. |
…shed lines" This reverts commit 191da07.
Merged
|
@skymakerolof you can close this PR. #121 fixes it. By the way, can you upload a new version of the library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LTYPE tables are used to get line properties, such as patterns to create dashed lines. This allows to use the
lineTypeNameproperty common to all entities. With this dxf viewers can create non continuous lines.