Refactors embedded youtube link regex

[ygrishajev]

So mobile link like 'http://m.youtube.com/...' can be embedded

[ygrishajev]

Just some detailed explanation of the issue that is fixed by this pull request:

Youtube link differ for its mobile version: 'https://m.youtube.com/...'. So when such link is pasted into video embed tooltip an error is thrown:

Refused to display 'https://www.youtube.com/...' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.

Steps for Reproduction

1. Visit http://quilljs.com
2. Try to embed youtube video (e.g. https://m.youtube.com/watch?v=IyTv_SR2uUo)
3. See console errors

Expected behavior:

1. Video is embedded properly
2. No console errors

Actual behavior:
Error is thrown

Platforms:
IOS, OSX

Version:

1.1.5

[jhchen]

Can you include tests? This regex is getting unwieldy with additional forms of YouTube links it is expected to support.

[benbro]

This is based on StackOverflow:

var reg = /^.*(youtu.be\/|v\/|u\/\w\/|embed\/|watch\?v=|\&v=)([a-zA-Z0-9_-]+).*/;
var match = value.trim().match(reg);
if (match && match[2].length == 11) {
 value = 'https://www.youtube.com/embed/' + match[2] + '?showinfo=0';
}

[stalniy]

@jhchen Hi, could you please tell where you would like these tests to be in test/ folder? https://github.com/quilljs/quill/blob/develop/test/unit/blots/block-embed.js or a separate file for like test/unit/theme/base.js

[stalniy]

@jhchen could you please answer the question above? It's critical for me to have this and I can finish the pull request (i.e., add tests)

[jhchen]

In terms of file organization it should probably go in theme/base.js since that is what is being tested. There may need to be some refactoring of the source code to enable unit testing which may influence which test/ folder or file it goes into.

[weavermedia]

+1 😃 We're currently running into this issue. Is there anything blocking this merge?

[stalniy]

As a workaround you can create own theme which extends SnowTheme and monkey patch Tooltip. This is what I did

[stalniy]

@ygrishajev you can close this. The work was finished in #1489