Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #158 - updating to latest slack-api-ref #159

Merged
merged 2 commits into from
Aug 17, 2017

Conversation

alexagranov
Copy link
Contributor

I don't believe there were any breaking changes introduced - but of course, we'll need to test.

Note there are 2 commits so that I could generate a proper standalone diff for the postEphemeral patch.

Along with CHANGELOG comments, added specs for postEphemeral that reflect the required options.

@dblock dblock merged commit 41539c6 into slack-ruby:master Aug 17, 2017
@dblock
Copy link
Collaborator

dblock commented Aug 17, 2017

Looks great, thanks for the update @alexagranov. Adding you here as well if you want to make a release.

@alexagranov alexagranov deleted the update_for_slack_api branch August 17, 2017 03:41
@alexagranov
Copy link
Contributor Author

@dblock Thanks, you paved the way ;-) Let me do some testing with my servers, then a couple days to catch the eclipse 🔭 If all goes well, I'll make a release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants