Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix api ref repo #177

Merged
merged 1 commit into from Nov 6, 2017
Merged

fix api ref repo #177

merged 1 commit into from Nov 6, 2017

Conversation

manuelmeurer
Copy link
Collaborator

@dangerpr-bot
Copy link

dangerpr-bot commented Nov 6, 2017 •
edited
Loading

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@dblock
Copy link
Collaborator

dblock commented Nov 6, 2017

See the Danger note above please, otherwise looks good.

@manuelmeurer
Copy link
Collaborator Author

manuelmeurer commented Nov 6, 2017 •
edited
Loading

I updated the changelog after seeing the Danger note and force-pushed. Should it not check the updated commit again?
Edit - oops sorry, didn't read the error properly. 😄

@dblock dblock merged commit 9e6ea96 into slack-ruby:master Nov 6, 2017
@dblock
Copy link
Collaborator

dblock commented Nov 6, 2017

Thanks!

@manuelmeurer manuelmeurer deleted the fix_api_ref_repo branch November 6, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelmeurer @dangerpr-bot @dblock