Allow either attachments or text #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This file is automatically generated by lib/tasks/web.rake from https://github.com/slack-ruby/slack-api-ref, take a look at how that's done. You either need to patch the API description similarly to what's in https://github.com/slack-ruby/slack-ruby-client/tree/master/lib/slack/web/api/patches or maybe even something upstream in the ref. |
|
@dblock How does it look now? Should I update the tests as well for CI to pass? |
|
Yes please, changelog & whatever the bot complains about until it's green. Thanks. |
|
@dblock Done 😄! I've also updated the date in the changelog for version |
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
chat_postEphemeral, eithertext:orattachments:is required, but the current code doesn't allow that (it checks thattext:always exist).