Updating Celluloid logger reference

[jlyonsmith]

No description provided.

[dblock]

First question, why is the integration test succeeding without this change? Or is Celluloid::Logger resolving automagically to Celluiloid::Internals::Logger?

Either way, please do rebase/squash the commits.

[jlyonsmith]

I don't see celluloid or celluloid-io pulled in by the .gemspec file (which makes sense as you are trying to dynamically support either one) Therefore you must have an older version installed on your dev box.

[dblock]

Hm, nope, https://travis-ci.org/dblock/slack-ruby-client/jobs/101613182#L107 has pulled in 0.17.2.

Locally you can run rm Gemfile.lock ; CONCURRENCY=celluloid-io SLACK_API_TOKEN=... bundle, then CONCURRENCY=celluloid-io SLACK_API_TOKEN=... rspec spec/integration.

What do you see when you run this?

[jlyonsmith]

I see 2 successful tests. What do you see with my merge? I'm running Ruby 2.0.0-p645.

RSpec.txt

[dblock]

I am saying that even without your merge I am seeing 2 successful tests.

[jlyonsmith]

You could try integrating slack-ruby-client into a new project with Celluloid and Reel and see what happens when you try and run it. It's definitely the case that the current version of Celluloid uses Celluloid::Internal::Logging

[dblock]

So what happens when you try to run it? What output do you get?

I know this is a trivial change and it seems like it's the right thing, I am just trying to understand what's going on, not being annoying :) I'd like a test that reproduces whatever error you're getting.

[jlyonsmith]

No problem. This reproduces the issue. Just run bundle ; SLACK_API_TOKEN=... ruby main.rb

Isn't spec_helper.rb missing require 'bundler/setup'?

test-ruby-slack-client.tar.gz

[dblock]

I figured it out, Celluiloid docs say in https://github.com/celluloid/celluloid:

You did require celluloid/current, which caused a subsequent require celluloid/io not to load the "backported" mode, the default. Adding that on top of celluloid.rb in slack-ruby-client reproduced the issue.

Fixed in dblock@33360aa. Can you try with gem 'slack-ruby-client', github: 'dblock/slack-ruby-client' to confirm? I'll cut a release then.

[jlyonsmith]

Confirmed that I everything builds fine now. Thanks!

[dblock]

@jlyonsmith I cut 0.5.3, thanks for your help.