Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint against Composition Locals that use get() = syntax #218

Closed
ZacSweers opened this issue Dec 1, 2023 · 0 comments · Fixed by #249
Closed

Lint against Composition Locals that use get() = syntax #218

ZacSweers opened this issue Dec 1, 2023 · 0 comments · Fixed by #249

Comments

@ZacSweers
Copy link
Collaborator

This should be a big error

internal actual val LocalThing:
  ProvidableCompositionLocal<Thing>
  get() = compositionLocalOf { Thing() }

vs

internal actual val LocalThing:
  ProvidableCompositionLocal<Thing> = compositionLocalOf { Thing() }
ZacSweers added a commit that referenced this issue Jan 24, 2024
@ZacSweers
Check for property accessors with composition locals
76d4c58 
Resolves #218
ZacSweers added a commit that referenced this issue Jan 24, 2024
@ZacSweers
Check for property accessors with composition locals
35abf62 
Resolves #218
@ZacSweers ZacSweers mentioned this issue Jan 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 24, 2024
@ZacSweers
Check for property accessors with composition locals (#249)
f333ae1 
* Check for property accessors with composition locals

Resolves #218

* Spotless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for property accessors with composition locals slackhq/compose-lints
1 participant
@ZacSweers