Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore context receivers in multiple content emissions lint #135

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

mrmans0n
Copy link
Collaborator

@mrmans0n mrmans0n commented Jun 9, 2023

Context receivers might make explicit the parent composable, like extension functions can do. As we can't know for sure whether the context receiver does contain something like a BoxScope/RowScope/ColumnScope or similar, we'd better ignore composables with context receivers for this rule, just to prevent false positives.

Fixes #129

@mrmans0n mrmans0n requested review from chrisbanes and ZacSweers June 9, 2023 18:29
@mrmans0n mrmans0n enabled auto-merge June 9, 2023 18:35
@mrmans0n mrmans0n added this pull request to the merge queue Jun 9, 2023
Merged via the queue into main with commit 91930d2 Jun 9, 2023
@mrmans0n mrmans0n deleted the multiemitters-ignore-context-receivers branch June 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComposeMultipleContentEmitters ignores context receiver
2 participants