Always include one non-local target during discovery #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Robinson <[email protected]>
demmer
reviewed
Jan 16, 2025
| targets[poolType] = targets[poolType][:b.numConnections] | ||
| // Always grab one non-local target to protect against a complete local failure. | ||
| nonLocal := targets[poolType][len(targets[poolType])-1] | ||
| targets[poolType] = append(targets[poolType][:b.numConnections], nonLocal) |
There was a problem hiding this comment.
Pedantically you should probably only slice to [:b.numConnections-1] so that the total conns are still the number that we set, it's just only N-1 of them are AZ-affine?
venkatraju
reviewed
Jan 16, 2025
| @@ -323,7 +323,9 @@ func (b *JSONGateResolverBuilder) parse() (bool, error) { | |||
| for poolType := range targets { | |||
| b.sorter.shuffleSort(targets[poolType], b.affinityField, b.affinityValue) | |||
| if len(targets[poolType]) > *numConnections { | |||
There was a problem hiding this comment.
nit: preexisting code and no change in behavior, but this should be if len(targets[poolType]) > b.numConnections {
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an entire AZ, or other affinity group, fails at once it's useful to have one backup target in another AZ. So let's grab one every time we set the targets for a given pool. The target should be shuffle-sorted to the end of the target list, so in the normal state it should never get used.