Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot Fix for CI: Removing C++ linter #1207

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Hot Fix for CI: Removing C++ linter #1207

merged 3 commits into from
Oct 7, 2024

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Oct 7, 2024 •
edited
Loading

Description

  • remove all the linting for now since cpplint is really only for c++ files
  • We should find another linter for these pure C files

@ruck314
Disable the build/include_what_you_use check
97fffc2 
Because C code use <stdio.h> instead of <cstdio> for C code
@ruck314 ruck314 requested a review from bengineerd October 7, 2024 20:45
bengineerd
bengineerd reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@bengineerd bengineerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want the include_what_you_use linting. We just just don't want to run in on non c++ files.

I think I'd rather remove all the linting for now since cpplint is really only for c++ files. We should find another linter for these pure C files.

@ruck314 ruck314 changed the title Updates to fix recent changes to the latest cpplint rules Hot Fix for CI: Removing C++ linter Oct 7, 2024
@ruck314
Copy link
Contributor Author

ruck314 commented Oct 7, 2024

@bengineerd I have applied your review comments

@ruck314 ruck314 merged commit 250d22f into pre-release Oct 7, 2024
1 check passed
@ruck314 ruck314 deleted the cpp-linter branch October 7, 2024 21:27
@ruck314 ruck314 mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengineerd bengineerd bengineerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruck314 @bengineerd