fix: Correctly parsing %-encoded URLs from .git/config file #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configparser module by default assumes that '%' characters indicate the presence of a variable and will try to parse a config value accordingly. Switching to "raw" mode prevents this behavior.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tdurk93
changed the title
Co-authored-by: kevin-orlando <[email protected]>
kevin-orlando
approved these changes
Nov 10, 2023
tdurk93
deleted the
feature/secureli-261-fix-config-parsing-with-url-encoded-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #261
The
configparsermodule by default assumes that '%' characters indicate the presence of a variable and will try to parse a config value accordingly. Switching to "raw" mode prevents this behavior.Testing
Manually tested by changing my
.git/configfile to set the origin URL to include%20, and was able to replicate the failure detailed in the ticket.