Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature/secureli 494 refactor action.py #556

Merged
merged 2 commits into from
Jun 3, 2024
Merged

feat: Feature/secureli 494 refactor action.py #556

merged 2 commits into from
Jun 3, 2024

Conversation

doug-szeto-slalom
Copy link
Contributor

secureli-494

Changes

  • creates _update_config helper function to be used in verify_install
  • creates _pre_install_checks helper function to be used in _install_secureli

Testing

  • no additional tests, existing tests pass

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

github-actions[bot]
github-actions bot previously requested changes May 30, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match (chore|style|test|feat|fix|docs|ci): .+

@doug-szeto-slalom doug-szeto-slalom changed the title Feature/secureli 494 refactor action.py feat: Feature/secureli 494 refactor action.py May 30, 2024
@github-actions github-actions bot dismissed their stale review May 30, 2024 14:59

All good!

@doug-szeto-slalom doug-szeto-slalom self-assigned this Jun 3, 2024
@doug-szeto-slalom doug-szeto-slalom merged commit 9620692 into main Jun 3, 2024
6 of 7 checks passed
@doug-szeto-slalom doug-szeto-slalom deleted the feature/secureli-494-refactor-action-py branch June 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itoltz itoltz itoltz approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@doug-szeto-slalom doug-szeto-slalom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doug-szeto-slalom @itoltz