Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored to use common git file repository class #568

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

ian-bowden-slalom
Copy link
Contributor

@ian-bowden-slalom ian-bowden-slalom commented Jun 13, 2024

secureli-XXX

This PR refactors GitRepo and RepoFilesRepository classes into a common GitRepo class which is an implementation of a new abstract class VersionControlRepoAbstraction. VersionControlRepoAbstraction replaces the RepoAbstraction class.

Changes

Testing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@ian-bowden-slalom ian-bowden-slalom linked an issue Jun 14, 2024 that may be closed by this pull request
@ian-bowden-slalom ian-bowden-slalom merged commit 7707615 into main Jun 18, 2024
6 checks passed
@ian-bowden-slalom ian-bowden-slalom deleted the feature/secureli-497-optimize-pii-scan-work branch June 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize PII scan work
2 participants