Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine tuning non container usage #134

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Fine tuning non container usage #134

merged 4 commits into from
Aug 23, 2019

Conversation

bangzek
Copy link
Contributor

@bangzek bangzek commented Aug 23, 2019

  • Add TwigMiddleware::create() helper
  • Move TwigContext::fromRequest() into Twig (cause it's a waste of class)
  • Document non container usage

@l0gicgate l0gicgate added this to the 3.0.0 milestone Aug 23, 2019
@l0gicgate
Copy link
Member

Looks good to me @adriansuter. After this, no more BCs please 😂 we're doing major release for this so.

@adriansuter
Copy link
Contributor

Nice work. Thanks.

@l0gicgate l0gicgate merged commit 288cd57 into slimphp:3.x Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bangzek @l0gicgate @adriansuter