Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node 12, update deps, fix PnP compatibility #1

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Require Node 12, update deps, fix PnP compatibility #1

merged 1 commit into from
Nov 30, 2021

Conversation

RDIL
Copy link

@RDIL RDIL commented Nov 28, 2021

  • Bump version to 1.5.0
  • Require Node 12, since 10 is EOL and D2 requires 12 anyway
  • Updated dependencies
  • Fix PnP (this package imports sharp and jimp but doesn't have them set as dependencies, which makes the require call unambiguous and unsound)

@RDIL RDIL mentioned this pull request Nov 28, 2021
Merged
3 tasks
@Josh-Cena
Copy link

@slorber Friendly ping as well

@RDIL RDIL mentioned this pull request Nov 29, 2021
Closed
@slorber
Copy link
Owner

slorber commented Nov 30, 2021

Thanks, LGTM 👍

@slorber slorber merged commit 4e13a0a into slorber:master Nov 30, 2021
@slorber
Copy link
Owner

slorber commented Nov 30, 2021

1.5 is published 👍 let me know if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RDIL @Josh-Cena @slorber