Move computesha256 to typescript #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Port the computesha256 from bash to typescript. Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
requested review from
asraa,
ianlewis,
laurentsimon and
joshuagl
as code owners
There was a problem hiding this comment.
Thanks @naveensrinivasan
Thanks for providing the link to the template you use, I'll take a look to learn a little more too
- Updated to use the native crypto library - Included README instructions - Some minor nits. Signed-off-by: naveensrinivasan <[email protected]>
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
force-pushed
the
naveen/feat/computesha256-ts
branch
from
4eb8c5b to
b9992ad
Compare
ianlewis
reviewed
Jul 18, 2022
Signed-off-by: naveensrinivasan <[email protected]>
- Included the workflow to validate the computesha256 github action Signed-off-by: naveensrinivasan <[email protected]>
ianlewis
reviewed
Jul 20, 2022
- Included permissions for the workflow - Renamed the workflow file - Updated the input variable to `path` - Changed the `run` function to non-async - Updated the README instructions - Included the tag for pinned SHA
naveensrinivasan
force-pushed
the
naveen/feat/computesha256-ts
branch
from
1ac1ea4 to
8bb45a9
Compare
Signed-off-by: naveensrinivasan <[email protected]>
|
NOTE: We need to mark the pre-submit as required after merge. |
added 2 commits
July 22, 2022 16:15
ianlewis
requested changes
Jul 22, 2022
- Moved the action within the pre-submit.actions.yml - Removed the redundant instructions in README Signed-off-by: naveensrinivasan <[email protected]>
ianlewis
approved these changes
Jul 25, 2022
|
@ianlewis @laurentsimon Thank you for all the review and feedback! Excited to have this merged! |
|
Great work @naveensrinivasan. The PR looks great! |
This was referenced Jul 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: naveensrinivasan [email protected]