Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

fix: venting issues #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: venting issues #236

wants to merge 2 commits into from

Conversation

NotSugden
Copy link
Contributor

@NotSugden NotSugden commented Jun 30, 2021 •
edited
Loading

This PR fixes some venting issues

  • The engineer can exit the vent if they are shifted on while in a vent
  • Phantom no longer runs into the vent
  • When the time lord rewinds, players in vents are shoved out
  • Phantom can only be clicked if they're within crew vision range of the player (even as impostor, because the phantom fades away if its more than crew vision distance away from the player)
    • I know this isn't a venting issue but I just added it anyway
  • Fixed engineer not being able to use a vent if they have the vent cleaning task there

@NotSugden NotSugden marked this pull request as draft July 29, 2021 22:31
@NotSugden
Copy link
Contributor Author

converting to draft as needs rebase

@NotSugden NotSugden force-pushed the fix-vent branch 2 times, most recently from e474c54 to e825676 Compare August 1, 2021 22:28
@NotSugden NotSugden marked this pull request as ready for review August 1, 2021 22:32
@NotSugden
fix: venting issues
da3050f 
fix(Phantom): change when phantom is set

fix: correct distance

fix(TimeLord): exit vent on time rewind

chore(csproj): add post-build action

fix(TimeLord): exit vent fix(Phantom): only allow click if moveable fix(Phantom): walk to vent

fix: vent cleaning task patch
@NotSugden NotSugden force-pushed the fix-vent branch 2 times, most recently from d346d05 to 8038795 Compare August 3, 2021 05:12
@stale
Copy link

stale bot commented Sep 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 2, 2021
@NotSugden
Copy link
Contributor Author

bump

@stale stale bot removed the wontfix This will not be worked on label Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NotSugden