This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 372
refactor: better ability handling #248
Open
NotSugden
wants to merge
4
commits into
slushiegoose:master
Choose a base branch
from
NotSugden:better-kill-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotSugden
changed the title
refactor: better kill button handling
refactor: better ability handling
Jul 8, 2021
This was referenced Jul 9, 2021
NotSugden
force-pushed
the
better-kill-handling
branch
from
July 12, 2021 07:35
782a4f4
to
7c99f93
Compare
on second thoughts, converting back to a draft for the moment |
NotSugden
force-pushed
the
better-kill-handling
branch
from
July 21, 2021 16:57
08ce8dc
to
03e01a4
Compare
Closed
NotSugden
force-pushed
the
better-kill-handling
branch
from
July 26, 2021 18:13
63c3de6
to
a6695c9
Compare
converting to draft as more issue(s) need to be addressed |
NotSugden
force-pushed
the
better-kill-handling
branch
from
July 29, 2021 21:31
a7b3d5d
to
2fb120a
Compare
NotSugden
force-pushed
the
better-kill-handling
branch
from
August 7, 2021 20:21
66cfe82
to
d81caa5
Compare
NotSugden
force-pushed
the
better-kill-handling
branch
from
August 7, 2021 20:23
d81caa5
to
8949b83
Compare
NotSugden
force-pushed
the
better-kill-handling
branch
from
August 9, 2021 17:56
63649aa
to
92ba64d
Compare
NotSugden
force-pushed
the
better-kill-handling
branch
from
August 10, 2021 21:00
ad8377e
to
8a18c07
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to better the handling for the role ability buttons
Full list of changes:
FixLights
RPC call in favour of theEngineerFix
RPC callExecutionerToJester
RPC call in favour of a localPlayerControl.Die
patchNEW BUGS INTRODUCED BY 2.2.0 FIXED BY THIS PR:
Status:
PR is ready, may need some tweaking but other than that its ready