Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

refactor: better ability handling #248

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NotSugden
Copy link
Contributor

@NotSugden NotSugden commented Jul 5, 2021

This PR aims to better the handling for the role ability buttons

Full list of changes:

  • Ability buttons now enable/disable with the HUD (eg, when opening the map the button is hidden, before the button would stay active)
  • Whenever a target is selected for a role's ability, the target gets an outline the same color as the role, so a Sheriff has a yellow target outline
  • Ability buttons cooldown only goes down while the player is not in a menu (same as impostor cooldown)
    • However, it still goes down with a task open, I have had feedback about this change and the majority prefer roles like sheriff to not have a reason to not do their tasks
  • Fixes any existing issues with the Altruist revive
  • Better vote handling
    • This also fixes the issue with all clients seeing a tie instead of a skip
  • If the Time Lord walks up to vitals, with the time lord can use vitals setting off, the use button doesn't highlight (previously the vitals screen would open and close immiedietly)
  • Removed FixLights RPC call in favour of the EngineerFix RPC call
  • Removed ExecutionerToJester RPC call in favour of a local PlayerControl.Die patch
  • Changed the internals of how the Shifter works
    • No longer needs to be updated it more Impostor roles are added (lol)
  • Morphling and Glitch morph/mimic abilities are now disabled if camo is active
  • The hack ability no longer breaks a shield
  • The Glitch's Mimic menu now has an exit button (Feature Request: Add a Close Button for the Glitch's Mimic Menu #176)
  • Refactored the internals of the hack ability (Permanent hack after death and meeting #250)
  • The Miner can no longer place vents in under the map positions
    • The miner vents can be placed in un-usable positions, but
  • Janitor, Undertaker and Altruist can no longer be used through walls
  • The check and X mark when voting now slide in for the mayor
  • Adds new Button Barry button sprite (provided by @dumbplayer2)
  • Fixed the mayor vote buttons not sliding in
  • Updated to 2021.6.30
  • Removes skip vote text from mayor abstain button
  • Removes kill text on all ability buttons

NEW BUGS INTRODUCED BY 2.2.0 FIXED BY THIS PR:

  • Swapper can actually get button barry (see here)
  • The correct kill sprite is used for sheriff/glitch kill buttons
  • The glitch can now have button barry, but the button is moved

Status:
PR is ready, may need some tweaking but other than that its ready

@NotSugden NotSugden changed the title refactor: better kill button handling refactor: better ability handling Jul 8, 2021
@NotSugden NotSugden force-pushed the better-kill-handling branch from 782a4f4 to 7c99f93 Compare July 12, 2021 07:35
@NotSugden NotSugden marked this pull request as ready for review July 12, 2021 07:44
@NotSugden
Copy link
Contributor Author

NotSugden commented Jul 12, 2021

PR is ready, just needs some more testing before being merged, no doubt with a PR this size theres probably an issue i didn't come across while making

on second thoughts, converting back to a draft for the moment

@NotSugden NotSugden marked this pull request as draft July 12, 2021 08:34
@NotSugden NotSugden marked this pull request as ready for review July 19, 2021 12:26
@NotSugden NotSugden force-pushed the better-kill-handling branch from 08ce8dc to 03e01a4 Compare July 21, 2021 16:57
@NotSugden NotSugden mentioned this pull request Jul 22, 2021
@NotSugden NotSugden force-pushed the better-kill-handling branch from 63c3de6 to a6695c9 Compare July 26, 2021 18:13
@NotSugden NotSugden marked this pull request as draft July 28, 2021 02:37
@NotSugden
Copy link
Contributor Author

converting to draft as more issue(s) need to be addressed

@NotSugden NotSugden force-pushed the better-kill-handling branch from a7b3d5d to 2fb120a Compare July 29, 2021 21:31
@NotSugden NotSugden force-pushed the better-kill-handling branch from 66cfe82 to d81caa5 Compare August 7, 2021 20:21
@NotSugden NotSugden force-pushed the better-kill-handling branch from d81caa5 to 8949b83 Compare August 7, 2021 20:23
@NotSugden NotSugden marked this pull request as ready for review August 7, 2021 20:23
@NotSugden NotSugden force-pushed the better-kill-handling branch from 63649aa to 92ba64d Compare August 9, 2021 17:56
@NotSugden NotSugden force-pushed the better-kill-handling branch from ad8377e to 8a18c07 Compare August 10, 2021 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant