Make arrows (camera controls) work in options menu #407
Conversation
src/game/options_menu.c
Outdated
| @@ -604,6 +604,46 @@ void optmenu_check_buttons(void) { | |||
| #endif | |||
| optmenu_opt_change(¤tMenu->opts[currentMenu->select], 0); | |||
| } | |||
| } else if (gPlayer1Controller->buttonPressed & D_CBUTTONS) { | |||
There was a problem hiding this comment.
not my branch, but I'd suggest combining the U/D with the stickY, and L/R with stickX.
something like
if (ABS(gPlayer1Controller->stickY) > 60 || (gPlayer1Controller->buttonPressed & (D_CBUTTONS|U_CBUTTONS)) {
...
if (gPlayer1Controller->stickY >= 60 || gPlayer1Controller->buttonPressed & D_CBUTTONS) {as you're copying/pasting a lot of common code this way
There was a problem hiding this comment.
I'm not really a skilled c programmer and really wanted this to work, so just copy pasted to do it myself. Of course if there is a cleaner way to implement the same functionality that is great. Just hope it gets committed in any form! And I completely understand what you're suggesting to change. This was my first attempt at a PR so not sure how to update it but may look into that...
There was a problem hiding this comment.
I have updated and resubmitted this. Not sure how to do things completely right with github so going to cancel this one.
That's all it does. It makes the camera buttons move around in the options menu. Makes it easier.