Blocklist 2 #579
Draft
Blocklist 2 #579
+416
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, added blacklist check for dirs without vcs
|
TODO:
Testing:
|
|
TODO:
Test:
|
| ) { | ||
| let mut candidates: Vec<PathBuf> = vec![path.clone()]; | ||
| let mut candidates: Vec<PathBuf> = vec![crate::files_correction::canonical_path(&path.to_string_lossy().to_string())]; |
There was a problem hiding this comment.
Here I think to_pathbuf_normalize needs to be used because canonical_path does not handle well Windows normalization, we still need to merge this to methods in the future, but for now we should use to_pathbuf_normalize
There was a problem hiding this comment.
Hmm I see canonical_path is also used a lot over the place, perhaps it's time to merge it with to_pathbuf_normalize (like to put logic of to_pathbuf_normalize into canonical_path)
| # | ||
|
|
||
| blocklist: | ||
| - "*/dist/*" |
There was a problem hiding this comment.
Shouldn't this be the same as the default list compiled in rust?
| vcs_folders.push(checkme.clone()); | ||
| let indexing_yaml_path = checkme.join(".refact").join("indexing.yaml"); | ||
| if indexing_yaml_path.exists() { | ||
| match crate::files_blocklist::load_indexing_yaml(&indexing_yaml_path, Some(&checkme)).await { |
There was a problem hiding this comment.
shouldn't reload indexing if needed be used here to not load the yaml multiple times while listing files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.