Make CPU cache interrogation an opt-in feature #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature has a measurable startup performance and for most modern CPUs, the cache line size is 64 anyway, so it doesn't make sense burning cycles to figure it out just for the odd case were the value is different
geoand
commented
Jan 20, 2025
| } | ||
|
|
||
| private static boolean determineCacheLevel() { | ||
| return Boolean.parseBoolean(System.getProperty("smallrye.cpu.determine-cache-level", "false")); |
There was a problem hiding this comment.
This name is far from ideal, so I'm certainly open to suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has a measurable startup performance
and for most modern CPUs, the cache line size is
64 anyway, so it doesn't make sense burning cycles to figure it out just for the odd case were the value is different