Do not skip a character if the env var character after a number is #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phabetic If the env var had the format FOO_BAR_1BAZ the second B was missed.
|
Thanks for the PR :) |
radcortez
pushed a commit
that referenced
this pull request
Feb 6, 2024
…phabetic (#1090) If the env var had the format FOO_BAR_1BAZ the second B was missed. Co-authored-by: Arvid Karlsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alphabetic
If the env var had the format FOO_BAR_1BAZ the second B was missed.
There was an error that occurred when we had an env var that combined both digits and alphabetical characters.
It turns out that if a digit is found, but its not an index in a map the character after the digit was missed.
This leads to
SRCFG00050: foo.bar.1 az in null does not map to any rootwhen trying to start an application that relies on Smallrye (example is Quarkus 3.5.0 and later)