Prevent erroneous validation failure for primitive type conversion #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually this needs a little more polish |
geoand
force-pushed
the
quarkus-29918
branch
from
e534d08 to
6b1742a
Compare
|
Should be good now |
geoand
commented
Dec 19, 2022
implementation/src/main/java/io/smallrye/config/ConfigMappingInterface.java
Outdated
Show resolved
Hide resolved
|
Thanks for the PR @geoand. My bad that I didn't handle this case properly :( |
|
No problem! I'll check out your suggestion tomorrow |
geoand
force-pushed
the
quarkus-29918
branch
from
6b1742a to
73f7236
Compare
radcortez
approved these changes
Dec 20, 2022
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: quarkusio/quarkus#29918