Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FaultToleranceExtension to switch metrics integration provider. #789

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

rhusar
Copy link
Contributor

@rhusar rhusar commented Mar 2, 2023

No description provided.

@rhusar
Copy link
Contributor Author

rhusar commented Mar 2, 2023

@Ladicek Please have a look, perhaps we can do something smarter/more useful, but this would suffice for WF integration.

@Ladicek Ladicek self-requested a review March 2, 2023 14:40
@Ladicek
Copy link
Contributor

Ladicek commented Mar 2, 2023

I think we'll eventually have to provide a way for the extension to discover the expected metrics integration in some other way, for the cases when CDI container instantiates the extension on its own, but this is good enough when the integrator can instantiate the extension themselves.

@Ladicek Ladicek added this to the 6.2.1 milestone Mar 2, 2023
@Ladicek Ladicek merged commit ff86e60 into smallrye:main Mar 2, 2023
@rhusar rhusar deleted the metrics branch March 2, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants