fix searching for fallback methods #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the algorithm that finds fallback methods in case of Kotlin `suspend` functions that declare an additional exception parameter. This additional parameter must be at the very end of the function signature, with the exception of Kotlin `suspend` functions, where the very last parameter must be the Kotlin `Continuation`. In this case, the exception parameter must be the _second last_.
|
Wow, that was quick. Thanks a lot for the fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the algorithm that finds fallback methods in case of Kotlin
suspendfunctions that declare an additional exception parameter. This additional parameter must be at the very end of the function signature, with the exception of Kotlinsuspendfunctions, where the very last parameter must be the KotlinContinuation. In this case, the exception parameter must be the second last.Fixes #828