Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concept: delete deprecated scheduler #923

Closed
wants to merge 2 commits into from
Closed

Concept: delete deprecated scheduler #923

wants to merge 2 commits into from

Conversation

magicprinc
Copy link
Contributor

Delete deprecated (unused) ScheduledExecutorTimeoutWatcher

Delete extra wrapper TimeoutWatch: use TimerTask directly, spare ~ 20 bytes per call

-2 Classes :-)

@Ladicek
Copy link
Contributor

Ladicek commented Nov 20, 2023

I agree with deleting the ScheduledExecutorService-based timer implementation, but I don't feel good about breaking the TimeoutWatch abstraction.

@Ladicek
Copy link
Contributor

Ladicek commented Nov 20, 2023

We could possibly remove the entire TimeoutWatcher abstraction altogether, it probably isn't all that useful.

@Ladicek
Copy link
Contributor

Ladicek commented Nov 20, 2023

Superseded by #927.

@Ladicek Ladicek closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicprinc @Ladicek