fix FaultTolerance.run() causing a NPE in async mode #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of `FaultTolerance.run()` simply delegated to `call()` with a `Callable` that produces `null`. In the async mode, the `null` is treated as a valid `CompletionStage`, which immediately results in a NPE. That NPE is subsequently caught and transformed into a failed `CompletionStage`, but it's better to not throw it at all. To be able to do this, the internal SPI `AsyncSupport` gains a new method that is able to create an already complete instance of the async type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
FaultTolerance.run()simply delegated tocall()with aCallablethat producesnull. In the async mode, thenullis treated as a validCompletionStage, which immediately results in a NPE. That NPE is subsequently caught and transformed into a failedCompletionStage, but it's better to not throw it at all.To be able to do this, the internal SPI
AsyncSupportgains a new method that is able to create an already complete instance of the async type.