Initial proposal of @Context feature
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Phillip Kruger <[email protected]>
|
Usage is as simple as injecting the Context anywhere you need it: |
Signed-off-by:Phillip Kruger <[email protected]>
Closed
andymc12
previously approved these changes
Jul 2, 2020
There was a problem hiding this comment.
I haven't looked at the test cases thoroughly, but I like the overall design. Only a few comments - neither of them are deal-breakers. Thanks @phillip-kruger!
Signed-off-by:Phillip Kruger <[email protected]>
Signed-off-by:Phillip Kruger <[email protected]>
…all build Signed-off-by:Phillip Kruger <[email protected]>
…all build Signed-off-by:Phillip Kruger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is facading some information from graphql-java's
DataFetchingEnviromentand also allow leaky abstraction to theDataFetchingEnviromentviaunwrap.I am sure is more we need to move into the
@Contextinterface, so please comment here.I think a good test would be to see if we can create custom SQL or JPA queries using the information in
Context(without having to use unwrap)Please look at the code in
APIas this is what will eventually move to the spec.Let me know what you think.
Signed-off-by:Phillip Kruger [email protected]