Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter schema improvement & bug fix #662

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

MikeEdgar
Copy link
Member

Fixes #659
Fixes #660
Resolves downstream issue quarkusio/quarkus#14865

Conflicts:
	core/src/main/java/io/smallrye/openapi/runtime/scanner/spi/AbstractParameterProcessor.java
Generate `allOf` when parameter schema is `ref` and local Bean
Validation or default value annotations are present.
@MikeEdgar MikeEdgar added this to the 2.1.2 milestone Feb 7, 2021
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeEdgar , you are a legend !! Thanks :)

@phillip-kruger phillip-kruger merged commit 965315e into smallrye:master Feb 7, 2021
@MikeEdgar MikeEdgar deleted the 659_improve_param_scan branch February 7, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference Schema Parameters drop local Schema information @Parameter(ref = ...) overwrites other parameters
2 participants