Add explicit jboss-logging-processor reference to compiler plugin #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xstefank
force-pushed
the
logging-annotation-processor
branch
from
365f9b1 to
d6b4821
Compare
|
I agree with the change, but we should also remove it from |
|
We might have to do that in a follow up to avoid breaking dependents. |
dmlloyd
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 23 changed the default annotation processing policy - https://inside.java/2024/06/18/quality-heads-up/#:~:text=Starting%20with%20JDK%2023%2C%20at,the%20default%20on%20JDK%2023.
This breaks tests in sr-health on JDK 23, so we need to declare the annotation processor explicitly.