Fixes #471 #563
Merged
Fixes #471 #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for `@Broadcast` on `Emitter` to broadcast to all subscribers
cescoffier
requested changes
May 28, 2020
There was a problem hiding this comment.
Awesome!
I believe the only missing bit is... updating the doc :-D.
Could you add in the Emitter documentation an example using the @broadcast?
Also, it might be useful to add a note in the @broadcast annotation to explain that it can also be used with @emitter (and so add a link to the other doc).
...ng-provider/src/main/java/io/smallrye/reactive/messaging/extension/EmitterConfiguration.java
Outdated
Show resolved
Hide resolved
...aging-provider/src/test/java/io/smallrye/reactive/messaging/inject/EmitterInjectionTest.java
Show resolved
Hide resolved
|
Yeah, I was so excited I got it working almost first go I forgot about docs! Will do that now |
|
Looks like Quay is having issues, containers can't be loaded for tests |
|
Failure on JDK 13 with AMQP, but think it's unrelated to the change |
cescoffier
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
@BroadcastonEmitterto broadcast to all subscribers