Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a flag to disable the readiness health check in the kafka connector #771

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

cescoffier
Copy link
Contributor

No description provided.

kenfinnigan
kenfinnigan previously approved these changes Sep 22, 2020
@cescoffier cescoffier force-pushed the readiness-healcheck-attribute branch from c198afd to d559026 Compare September 25, 2020 08:06
@cescoffier cescoffier merged commit 66c0ef4 into master Sep 25, 2020
@cescoffier cescoffier deleted the readiness-healcheck-attribute branch September 25, 2020 13:27
@cescoffier cescoffier linked an issue Sep 25, 2020 that may be closed by this pull request
@andreas-eberle
Copy link

andreas-eberle commented Nov 11, 2020

@cescoffier: I tried setting health-readiness-enabled and health-enabled to false for a topic with a pattern name (#768) like this

mp.messaging.incoming.my-events.health-enabled=false

Unfortunately, the health check still fails with a TimeoutException:

Caused by: org.apache.kafka.common.errors.TimeoutException: Timed out waiting for a node assignment.

Did I configure the property wrong?

@cescoffier
Copy link
Contributor Author

Readiness or liveness? Did you try to disable all health checks?

@andreas-eberle
Copy link

Ah, sorry, I just found an old quarkus.kafka.health.enabled=true flag in my application.properties. After removing that, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive messaging health check fails if no topic name is specified
3 participants