Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Unresolved Inherited Shared Dependencies #633

Closed
FlorianRappl opened this issue Oct 16, 2023 · 0 comments
Closed

Ignore Unresolved Inherited Shared Dependencies #633

FlorianRappl opened this issue Oct 16, 2023 · 0 comments
Assignees
Labels
cli Concerns the piral-cli application. enhancement New feature or request
Milestone

Comments

@FlorianRappl
Copy link
Contributor

New Feature Proposal

For more information, see the CONTRIBUTING guide.

Description

All dependencies from the importmap are resolved to find their entry point - this is done even though some dependency might not even be used and therefore not installed. Right now this leads to problems - forcing the user to install these (unused) inherited shared dependencies.

We should ignore those dependencies. While dependencies of the importmap that are explicitly (i.e., not inherited) specified there should still throw if unresolved, these other (implicit) dependencies should just be ignored.

Background

We've seen these in some projects that have a lot of (centrally) shared dependencies. Now, teams that create pilets for those app shells are quite often only using a subset of the available dependencies. To optimize this a bit they usually drop the shared dependencies from their package.json.

Discussion

Should we print something when we ignore a shared dependency? I think a warning would be wrong - after all, since nothing is installed this is supposingly anyway wanted. If not, then an error would be thrown during bundling anyway... However, I think a small info (ignoring inherited dependency "<name.here>") would still be good.

Any thoughts on this?

@FlorianRappl FlorianRappl added enhancement New feature or request cli Concerns the piral-cli application. in-review The item is currently being reviewed. labels Oct 16, 2023
@FlorianRappl FlorianRappl added this to the 1.3.1 milestone Oct 16, 2023
@FlorianRappl FlorianRappl self-assigned this Oct 16, 2023
@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. and removed in-review The item is currently being reviewed. in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. labels Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Concerns the piral-cli application. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant