fix: improve FHIR-root-URL parsing to cover more cases #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
mikix/url-parsing
branch
from
d6b7a26 to
9d4455e
Compare
dogversioning
approved these changes
Jan 15, 2025
mikix
force-pushed
the
mikix/url-parsing
branch
from
9d4455e to
a039bac
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Before, we were just using some regexes on the URL, but let's actually use a parser and separate out the pieces. This is better in general, but also happens to let us handle cases like the user putting an export URL like ".../$export?_type=..." on the shell, having the shell zero-out the $export string because it thinks it is a variable, and then us seeing a URL like "/?_type=..." (which isn't really a valid URL, but we will insert missing $export strings later in the process). As part of this, I refactored some instances of URL parsing into one single FhirUrl class, which we can build upon in the future as needed.
mikix
force-pushed
the
mikix/url-parsing
branch
from
a039bac to
3a5a0e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were just using some regexes on the URL, but let's actually use a parser and separate out the pieces.
This is better in general, but also happens to let us handle cases like the user putting an export URL like ".../$export?_type=..." on the shell, having the shell zero-out the $export string because it thinks it is a variable, and then us seeing a URL like "/?_type=..." (which isn't really a valid URL, but we will insert missing $export strings later in the process).
As part of this, I refactored some instances of URL parsing into one single FhirUrl class, which we can build upon in the future as needed.
Checklist
docs/) needs to be updated