Added ICD10 description tiers #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
force-pushed
the
mg/umls_descriptions
branch
from
b0052d3 to
010d5c3
Compare
comorbidity
reviewed
Jan 13, 2025
| -- A collection of convenience views for UMLS data | ||
|
|
||
| -- Selecting only child relationships FROM mrrel | ||
| CREATE TABLE IF NOT EXISTS umls__mrrel_is_a AS |
There was a problem hiding this comment.
This umls__mrrel_is_a only applies to DRUGS, recommend changing name to
umls__mrrel_drug_is_a
comorbidity
previously requested changes
Jan 13, 2025
|
Looks good very minor requested name change. |
dogversioning
force-pushed
the
mg/umls_descriptions
branch
from
a2d5a20 to
470ddb8
Compare
mikix
approved these changes
Jan 14, 2025
| @@ -44,7 +44,8 @@ testpaths = [ | |||
| ] | |||
|
|
|||
| [tool.ruff] | |||
| target-version = "py310" | |||
| target-version = "py311" | |||
| line-length = 100 | |||
There was a problem hiding this comment.
You were feeling like 100 was too much for your tastes, after living with it for a bit, yeah? I'm fine if you want to keep the default going.
There was a problem hiding this comment.
Yeah it's fine - mostly I'm here for 'just do it this one way and don't spend time debating it'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add some utility views into the data around ICD coding, by doing the following:
It also updates the UMLS study to be compatible with library v4, and writes the version of UMLS data used to the transaction log.