Support a flat ndjson dir layout as well as a hierarchical one #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, --load-ndjson-dir would only look for an ETL output-style format like this: dir/condition/*.ndjson dir/patient/*.ndjson But now it will also look for flat files as well (i.e. ETL input-style format) like this: dir/1.Patient.ndjson dir/Patient.october.ndjson dir/Patient.ndjson This will make it nicer to use the --load-ndjson-dir flow when you are working on ndjson files directly, without going through Cumulus ETL first.
dogversioning
approved these changes
May 29, 2024
There was a problem hiding this comment.
I think this needs some documentation tweaks for the public site (mostly here: https://docs.smarthealthit.org/cumulus/library/creating-studies.html#testing-studies), but otherwise seems totally reasonable.
Added a new commit to update that page (the only doc page that mentioned --load-ndjson-dir) to basically drop the ETL step entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, --load-ndjson-dir would only look for an ETL output-style format like this:
dir/condition/*.ndjsondir/patient/*.ndjsonBut now it will also look for flat files as well (i.e. ETL input-style format) like this:
dir/1.Patient.ndjson
dir/Patient.october.ndjson
dir/Patient.ndjson
This will make it nicer to use the --load-ndjson-dir flow when you are working on ndjson files directly, without going through Cumulus ETL first.
Checklist
docs/) needs to be updated