CRIB-411: removing redundant call to cribbit.sh #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfelix
force-pushed
the
CRIB-411/removing-cribbit-sh
branch
2 times, most recently
from
b83c6a2 to
804d93d
Compare
rafaelfelix
force-pushed
the
CRIB-411/removing-cribbit-sh
branch
from
804d93d to
e4c463a
Compare
njegosrailic
approved these changes
Nov 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cribbit.sh is deprecated
Also, the CRIB CLI has the logic to ensure the namespace is ready (which includes waiting for the rolebinding creation), so no need to sleep before calling it anymore