Improve CCIP Contract Reader Querying #267
Conversation
ilija42
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
|
Nice, not sure if you've seen this, but we actually have tickets to fix that for this sprint :D |
Well, a few tickets less for your sprint lol, I wanted to help with this and modifiers to see how is it to use the interface in practice |
ilija42
force-pushed
the
CCIP-2896-contract-reader-querying-improvements
branch
from
d12f8fd to
1048b34
Compare
ilija42
force-pushed
the
CCIP-2896-contract-reader-querying-improvements
branch
from
1048b34 to
816f0fb
Compare
| query.Comparator(consts.EventAttributeState, primitives.ValueComparator{ | ||
| Value: 0, | ||
| Operator: primitives.Gt, | ||
| }), |
There was a problem hiding this comment.
Do we need to add postgres indexes for any of these datawords? If not, this could be very slow.
If we do need to add them, I wonder if there's a way we could add them only to chainlink-ccip's fork but not to chainlink?
There was a problem hiding this comment.
Yeah, probably will require some kind of detailed indexing. We have a task planned as performance work to go over all the DB queries we make from the ccipreader to better understand where we miss indexing/limits/paging etc
https://smartcontract-it.atlassian.net/browse/CCIP-3870
There was a problem hiding this comment.
However, in the long term we will probably need ChainReader's tables to be optimized for the specific products, for instance by
- by having custom indexes per product
- or having custom indexers and tables per product (for instance, the ability to dynamically index events in dedicated tables to limit the scans sizes)
ilija42
force-pushed
the
CCIP-2896-contract-reader-querying-improvements
branch
from
816f0fb to
9d45bb2
Compare
ilija42
force-pushed
the
CCIP-2896-contract-reader-querying-improvements
branch
from
9d45bb2 to
0cf44c0
Compare
|
Integration tests are failing, that's because we need a updates to the contract reader config right? @ilija42 |
Have to merge core first |
|
mateusz-sekara
deleted the
CCIP-2896-contract-reader-querying-improvements
branch
related core PR smartcontractkit/chainlink#14935
Also relates to
CCIP-3866
and
CCIP-3865