Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/loop: grpc proxy MedianProvider connections #144

Merged
merged 1 commit into from
Aug 8, 2023
Merged

pkg/loop: grpc proxy MedianProvider connections #144

merged 1 commit into from
Aug 8, 2023

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Jul 31, 2023 •
edited
Loading

@jmank88 jmank88 temporarily deployed to integration July 31, 2023 12:06 — with GitHub Actions Inactive
@jmank88 jmank88 mentioned this pull request Jul 31, 2023
Merged
@jmank88 jmank88 changed the title WIP pkg/loop: grpc proxy MedianProvider connections Jul 31, 2023
@jmank88 jmank88 temporarily deployed to integration July 31, 2023 12:23 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2364-grpc-proxy branch from abc497e to e9e3288 Compare July 31, 2023 22:34
@jmank88 jmank88 temporarily deployed to integration July 31, 2023 22:34 — with GitHub Actions Inactive
@patrickhuie19 patrickhuie19 mentioned this pull request Aug 3, 2023
Merged
@jmank88 jmank88 force-pushed the BCF-2364-grpc-proxy branch from e9e3288 to 275fbe8 Compare August 3, 2023 21:33
@jmank88 jmank88 temporarily deployed to integration August 3, 2023 21:33 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2364-grpc-proxy branch from 275fbe8 to 9fc8a35 Compare August 3, 2023 22:21
@jmank88 jmank88 temporarily deployed to integration August 3, 2023 22:21 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2364-grpc-proxy branch from 9fc8a35 to 069832c Compare August 3, 2023 22:25
@jmank88 jmank88 temporarily deployed to integration August 3, 2023 22:25 — with GitHub Actions Inactive
@jmank88 jmank88 marked this pull request as ready for review August 3, 2023 22:27
@jmank88 jmank88 requested a review from krebernisak as a code owner August 3, 2023 22:27
@jmank88 jmank88 requested a review from patrickhuie19 August 3, 2023 23:22
@jmank88 jmank88 requested a review from krehermann August 3, 2023 23:22
patrickhuie19
patrickhuie19 previously approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice!

@jmank88 jmank88 force-pushed the BCF-2364-grpc-proxy branch from 069832c to 45dfdfd Compare August 8, 2023 13:41
@jmank88 jmank88 temporarily deployed to integration August 8, 2023 13:41 — with GitHub Actions Inactive
@jmank88 jmank88 requested a review from patrickhuie19 August 8, 2023 13:41
@jmank88
Copy link
Collaborator Author

jmank88 commented Aug 8, 2023

Rebased

@jmank88 jmank88 merged commit 4e20b07 into main Aug 8, 2023
@jmank88 jmank88 deleted the BCF-2364-grpc-proxy branch August 8, 2023 14:12
This was referenced Aug 9, 2023
Closed
Merged
cedric-cordenier pushed a commit that referenced this pull request Sep 6, 2023
@jmank88 @cedric-cordenier
pkg/loop: grpc proxy MedianProvider connections (#144)
26a90dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@krebernisak krebernisak Awaiting requested review from krebernisak

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @patrickhuie19