-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic heartbeat service #976
Draft
patrickhuie19
wants to merge
1
commit into
main
Choose a base branch
from
feature/KS-460/heartbeat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
package services | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"time" | ||
|
||
"github.com/smartcontractkit/chainlink-common/pkg/logger" | ||
"github.com/smartcontractkit/chainlink-common/pkg/timeutil" | ||
) | ||
|
||
// Heartbeat is a usage of Engine for application specific heartbeats, | ||
// used in the core node and for loops. It accepts a named logger, | ||
// a beat, a setup func to initialize resources used on each beat, | ||
// a beat function to define the behavior on each beat, and a close func | ||
// for resource teardown | ||
type Heartbeat struct { | ||
Service | ||
eng *Engine | ||
|
||
beat time.Duration | ||
lggr logger.Logger | ||
} | ||
|
||
func NewHeartbeat( | ||
lggr logger.Logger, | ||
beat time.Duration, | ||
setupFn func(ctx context.Context) error, | ||
beatFn func(bCtx context.Context), | ||
closeFn func() error, | ||
) Heartbeat { | ||
h := Heartbeat{ | ||
beat: beat, | ||
lggr: lggr, | ||
} | ||
startFn := func(ctx context.Context) error { | ||
err := setupFn(ctx) | ||
if err != nil { | ||
return fmt.Errorf("setting up heartbeat: %w", err) | ||
} | ||
|
||
// consistent tick period | ||
constantTickFn := func() time.Duration { | ||
return h.beat | ||
} | ||
|
||
// TODO allow for override of tracer provider in engine | ||
// TODO wrap beatFn in engine trace | ||
h.eng.GoTick(timeutil.NewTicker(constantTickFn), beatFn) | ||
return nil | ||
} | ||
|
||
h.Service, h.eng = Config{ | ||
Name: fmt.Sprintf("%s.%s", lggr.Name(), "heartbeat"), | ||
Start: startFn, | ||
Close: closeFn, | ||
}.NewServiceEngine(lggr) | ||
return h | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we pass beholder client as a dependency here as well. Its same type of concern as logger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - my thinking with breaking this out was that this heartbeat service could be used in core, loops, and the beholder client as well