Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRE-39] (fix): Add more guards & nil checks to WASM compute #984

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[CRE-39] (fix): Add more guards & nil checks to WASM compute #984

wants to merge 5 commits into from
+94 −22

Conversation

justinkaseman
Copy link
Contributor

No description provided.

@justinkaseman justinkaseman requested a review from a team as a code owner January 7, 2025 23:56
@justinkaseman justinkaseman requested a review from a team January 7, 2025 23:57
@chudilka1 chudilka1 self-requested a review January 8, 2025 11:37
chudilka1
chudilka1 requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@chudilka1 chudilka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinkaseman, would you be so kind as to add unit tests for the changes? ATM, the coverage for these files is 50% (the required is > 75%)

agparadiso
agparadiso previously approved these changes Jan 9, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agparadiso agparadiso agparadiso left review comments

@chudilka1 chudilka1 Awaiting requested review from chudilka1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkaseman @agparadiso @chudilka1