Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiNode Integration: Initial Setup #824

Merged
merged 29 commits into from
Sep 20, 2024
Merged

MultiNode Integration: Initial Setup #824

merged 29 commits into from
Sep 20, 2024

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Aug 20, 2024 •
edited
Loading

Description

Initial setup for MultiNode integration.

  • Added common MultiNode files [/multinode folder will be extracted to a common repo later]
  • Modified local MutliNode metric naming to avoid duplicates
  • Created outline for required configs
  • Created StringID type for MultiNode integration
  • Extended chain and client for MultiNode integration with feature flag

Closes https://smartcontract-it.atlassian.net/browse/BCI-4060

Requires Dependencies

Chain Agnostic Multinode PR: smartcontractkit/chainlink#13386
MultiNode updates will be copied into Solana until MultiNode code is extracted.

@DylanTinianov DylanTinianov self-assigned this Aug 20, 2024
@DylanTinianov DylanTinianov changed the title MultiNode integration setup MultiNode Integration Setup Aug 21, 2024
@DylanTinianov DylanTinianov mentioned this pull request Sep 18, 2024
Merged
dhaidashenko
dhaidashenko previously approved these changes Sep 19, 2024
View reviewed changes
pkg/solana/chain_test.go Outdated Show resolved Hide resolved
pkg/solana/client/client.go
return 0
}
//nolint:gosec
return int64(*h.BlockHeight)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a legacy from the initial iteration to create generalized components. I'm not sure why it was defined as int64.
I agree with Dylan that we should keep this change out of scope for the MultiNode PR

dhaidashenko
dhaidashenko previously approved these changes Sep 19, 2024
View reviewed changes
@aalu1418 aalu1418 enabled auto-merge (squash) September 20, 2024 12:19
@aalu1418 aalu1418 merged commit 6ad738f into develop Sep 20, 2024
32 checks passed
@aalu1418 aalu1418 deleted the BCI-2835-integrate-multinode branch September 20, 2024 12:40
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@dhaidashenko dhaidashenko dhaidashenko left review comments

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @dhaidashenko @aalu1418